wgtmac commented on code in PR #1394:
URL: https://github.com/apache/orc/pull/1394#discussion_r1094734698
##########
c++/include/orc/Writer.hh:
##########
@@ -262,6 +262,19 @@ namespace orc {
* @return if not set, the default is false
*/
bool getUseTightNumericVector() const;
+
+ /**
+ * Set the initial buffer capacity of output stream.
Review Comment:
```suggestion
* Set the initial capacity to the output buffer of the compressed
stream.
```
##########
c++/include/orc/Writer.hh:
##########
@@ -262,6 +262,19 @@ namespace orc {
* @return if not set, the default is false
*/
bool getUseTightNumericVector() const;
+
+ /**
+ * Set the initial buffer capacity of output stream.
+ * Each column contains multiple output streams with buffers,
Review Comment:
```suggestion
* Each column contains one or more compressed streams depending on its
type,
```
##########
c++/include/orc/Writer.hh:
##########
@@ -262,6 +262,19 @@ namespace orc {
* @return if not set, the default is false
*/
bool getUseTightNumericVector() const;
+
+ /**
+ * Set the initial buffer capacity of output stream.
+ * Each column contains multiple output streams with buffers,
+ * and these buffers will automatically expand when memory is exhausted.
Review Comment:
Correct me if I am wrong here.
##########
c++/include/orc/Writer.hh:
##########
@@ -262,6 +262,19 @@ namespace orc {
* @return if not set, the default is false
*/
bool getUseTightNumericVector() const;
+
+ /**
+ * Set the initial buffer capacity of output stream.
+ * Each column contains multiple output streams with buffers,
+ * and these buffers will automatically expand when memory is exhausted.
Review Comment:
```suggestion
* and these buffers will automatically expand when necessary but up to
the compression block size.
```
##########
c++/include/orc/Writer.hh:
##########
@@ -262,6 +262,19 @@ namespace orc {
* @return if not set, the default is false
*/
bool getUseTightNumericVector() const;
+
+ /**
+ * Set the initial buffer capacity of output stream.
+ * Each column contains multiple output streams with buffers,
+ * and these buffers will automatically expand when memory is exhausted.
+ */
+ WriterOptions& setOutputBufferCapacity(uint64_t capacity);
+
+ /**
+ * Get the buffer capacity of output stream.
Review Comment:
```suggestion
* Get the initial capacity of output buffer in the compressed stream.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
