wgtmac commented on code in PR #1394:
URL: https://github.com/apache/orc/pull/1394#discussion_r1095366122
##########
c++/include/orc/Writer.hh:
##########
@@ -262,6 +262,19 @@ namespace orc {
* @return if not set, the default is false
*/
bool getUseTightNumericVector() const;
+
+ /**
+ * Set the initial buffer capacity of output stream.
+ * Each column contains multiple output streams with buffers,
Review Comment:
Then it makes sense to me to use `BufferedOutputStream` explicitly. We have
defined several output streams (e.g. one from `OrcFile.hh`). It should be clear
to user which one we are referring to.
##########
c++/include/orc/Writer.hh:
##########
@@ -262,6 +262,19 @@ namespace orc {
* @return if not set, the default is false
*/
bool getUseTightNumericVector() const;
+
+ /**
+ * Set the initial buffer capacity of output stream.
+ * Each column contains multiple output streams with buffers,
+ * and these buffers will automatically expand when memory is exhausted.
Review Comment:
In the `CompressionStream`, will the output buffer exceed the compression
block size?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
