wgtmac commented on PR #1375: URL: https://github.com/apache/orc/pull/1375#issuecomment-1432441361
> Hi @wgtmac @coderex2522 , I just modified the code follow your suggestions, please check it. Thank you very much for your help! 1.Modified the CMakelists, delete the part of aarch64 and ORC_RUNTIME_SIMD_LEVEL, also changed the printed message content 2.Modified the print content and style about BUILD_ENABLE_AVX512, CXX_SUPPORTS_AVX512, ORC_HAVE_RUNTIME_AVX512 and ORC_SIMD_LEVEL Delete the print of CXX_SUPPORTS_AVX512 Below is the print information in the cmake process: -- System processor: x86_64 -- Performing Test CXX_SUPPORTS_AVX512 -- Performing Test CXX_SUPPORTS_AVX512 - Success -- BUILD_ENABLE_AVX512: ON -- Enable the AVX512 vector decode of bit-packing, compiler support AVX512 -- ORC_HAVE_RUNTIME_AVX512: ON, ORC_SIMD_LEVEL: AVX512 > > -- System processor: x86_64 -- Performing Test CXX_SUPPORTS_AVX512 -- Performing Test CXX_SUPPORTS_AVX512 - Success -- BUILD_ENABLE_AVX512: OFF -- Disable the AVX512 vector decode of bit-packing -- ORC_HAVE_RUNTIME_AVX512: OFF, ORC_SIMD_LEVEL: NONE 3.Separate the configuration of AVX512 from CMakelists, and create a new cmake module "cmake_modules/ConfigSimdLevel.cmake" file 4.The default value of BUILD_ENABLE_AVX512 is still ON. Do we need to change it back to OFF? 5.Modified the style of code comments 6.Delete message(FATAL_ERROR "Unknown system processor"), to avoid break down the build process. Let's fix the CI check first. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
