wgtmac commented on code in PR #1375:
URL: https://github.com/apache/orc/pull/1375#discussion_r1109449067
##########
c++/test/TestRleVectorDecoder.cc:
##########
@@ -106,7 +106,12 @@ namespace orc {
int32_t lpad = offset * BARWIDTH / total;
int32_t rpad = BARWIDTH - lpad;
- printf("\r%s:%3d%% [%.*s%*s] [%ld /%ld]", testName, val, lpad, BARSTR,
rpad, "", offset, total);
+#ifdef __APPLE__
+ printf("\r%s:%3d%% [%.*s%*s] [%lld/%lld]", testName, val, lpad, BARSTR,
rpad, "", offset,
Review Comment:
Please do not use printf as different platforms may have different
semantics. Use modern C++ as much as possible. We support C++17 now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
