wgtmac commented on code in PR #1427:
URL: https://github.com/apache/orc/pull/1427#discussion_r1129345134
##########
c++/include/orc/Type.hh:
##########
@@ -65,6 +67,7 @@ namespace orc {
virtual std::vector<std::string> getAttributeKeys() const = 0;
virtual std::string getAttributeValue(const std::string& key) const = 0;
virtual std::string toString() const = 0;
+ virtual std::optional<const Type*> getTypeByColumnId(uint64_t colId) const
= 0;
Review Comment:
I didn’t notice that this is a public header. As Apache impala is still on
c++14 and ‘optional’ is a c++17 feature, it will break impala. Could you revert
this and add a comment for the possible nullptr of return? Sorry about that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
