coderex2522 commented on code in PR #1427: URL: https://github.com/apache/orc/pull/1427#discussion_r1133266823
########## c++/src/SchemaEvolution.cc: ########## @@ -0,0 +1,259 @@ +#include "SchemaEvolution.hh" +#include "orc/Exceptions.hh" + +#include <unordered_map> Review Comment: These two header files are already included in the SchemaEvolution.hh. It is a redundant code. ########## c++/src/SchemaEvolution.hh: ########## @@ -0,0 +1,45 @@ +#ifndef ORC_SCHEMA_EVOLUTION_HH +#define ORC_SCHEMA_EVOLUTION_HH + +#include <unordered_map> +#include <unordered_set> +#include "orc/Type.hh" Review Comment: It is recommended that this line ' #include "orc/Type.hh" ' be moved to precede line ' #include <unordered_map>'. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
