wpleonardo commented on code in PR #1375: URL: https://github.com/apache/orc/pull/1375#discussion_r1141576118
########## c++/test/TestRleVectorDecoder.cc: ########## @@ -0,0 +1,561 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include <cstdlib> + +#include "MemoryOutputStream.hh" +#include "RLEv2.hh" +#include "wrap/gtest-wrapper.h" +#include "wrap/orc-proto-wrapper.hh" + +#ifdef __clang__ +DIAGNOSTIC_IGNORE("-Wmissing-variable-declarations") +#endif + +namespace orc { + using ::testing::TestWithParam; + using ::testing::Values; + + const int DEFAULT_MEM_STREAM_SIZE = 1024 * 1024; // 1M + const char finish = '#'; + std::string flags = "-\\|/"; + + class RleV2BitUnpackAvx512Test : public TestWithParam<bool> { + virtual void SetUp(); + + protected: + bool alignBitpacking; + std::unique_ptr<RleEncoder> getEncoder(RleVersion version, MemoryOutputStream& memStream, + bool isSigned); + + void runExampleTest(int64_t* inputData, uint64_t inputLength, unsigned char* expectedOutput, + uint64_t outputLength); + + void runTest(RleVersion version, uint64_t numValues, int64_t start, int64_t delta, bool random, + bool isSigned, uint8_t bitWidth, uint64_t blockSize = 0, uint64_t numNulls = 0); + }; + + void vectorDecodeAndVerify(RleVersion version, const MemoryOutputStream& memStream, int64_t* data, + uint64_t numValues, const char* notNull, uint64_t blockSize, + bool isSinged) { + std::unique_ptr<RleDecoder> decoder = + createRleDecoder(std::unique_ptr<SeekableArrayInputStream>(new SeekableArrayInputStream( + memStream.getData(), memStream.getLength(), blockSize)), + isSinged, version, *getDefaultPool(), getDefaultReaderMetrics()); + + int64_t* decodedData = new int64_t[numValues]; + decoder->next(decodedData, numValues, notNull); + + for (uint64_t i = 0; i < numValues; ++i) { + if (!notNull || notNull[i]) { + EXPECT_EQ(data[i], decodedData[i]); + } + } + + delete[] decodedData; + } + + void RleV2BitUnpackAvx512Test::SetUp() { + alignBitpacking = GetParam(); + } + + void generateDataFolBits(uint64_t numValues, int64_t start, int64_t delta, bool random, Review Comment: Done. ########## c++/test/CMakeLists.txt: ########## @@ -18,6 +18,10 @@ include_directories( set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${CXX17_FLAGS} ${WARN_FLAGS}") +if(BUILD_ENABLE_AVX512) + set(SIMD_TEST TestRleVectorDecoder.cc) Review Comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
