wpleonardo commented on code in PR #1375: URL: https://github.com/apache/orc/pull/1375#discussion_r1141583305
########## c++/src/CMakeLists.txt: ########## @@ -184,13 +184,21 @@ set(SOURCE_FILES Timezone.cc TypeImpl.cc Vector.cc - Writer.cc) + Writer.cc + CpuInfoUtil.cc + BpackingDefault.cc) Review Comment: Already sort them alphabetically. The reason for CpuInfoUtil.cc building default is [RleDecoderV2.cc] readLongs => [Dispatch.hh] DynamicDispatch => Resolve The function Resolve uses CpuInfo to judge if the CPU supports the current Bit-unpacking function. So I feel that keeping CpuInfoUtil.cc in the default building source file list, maybe better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
