coderex2522 commented on code in PR #1469:
URL: https://github.com/apache/orc/pull/1469#discussion_r1166207392
##########
c++/src/ColumnReader.cc:
##########
@@ -100,13 +100,16 @@ namespace orc {
return;
}
}
+ rowBatch.hasNulls = false;
} else if (incomingMask) {
// If we don't have a notNull stream, copy the incomingMask
rowBatch.hasNulls = true;
memcpy(rowBatch.notNull.data(), incomingMask, numValues);
return;
+ } else {
+ memset(rowBatch.notNull.data(), 1, numValues);
+ rowBatch.hasNulls = false;
}
- rowBatch.hasNulls = false;
Review Comment:
In addition, it is no necessary to repeat this line of code twice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
