wgtmac commented on code in PR #1469:
URL: https://github.com/apache/orc/pull/1469#discussion_r1179861116
##########
c++/include/orc/Vector.hh:
##########
@@ -37,6 +37,8 @@ namespace orc {
* The base class for each of the column vectors. This class handles
* the generic attributes such as number of elements, capacity, and
* notNull vector.
+ * Note: Because we don't reset notNull buffer if hasNulls == false for
better performance,
+ * it need to check hasNull firstly, and then check notNull buffer.
Review Comment:
```suggestion
* it need to check hasNull first, and then check notNull buffer only if
hasNull is true.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
