dongjoon-hyun commented on code in PR #1574:
URL: https://github.com/apache/orc/pull/1574#discussion_r1287398171
##########
java/core/src/java/org/apache/orc/DataReader.java:
##########
@@ -52,10 +52,9 @@ BufferChunkList readFileData(BufferChunkList range,
boolean isTrackingDiskRanges();
/**
- * Releases buffers created by readFileData. See readFileData javadoc.
- * @param toRelease The buffer to release.
+ * Releases all buffers created by readFileData. See readFileData javadoc.
*/
- void releaseBuffer(ByteBuffer toRelease);
+ void releaseAllBuffers();
Review Comment:
No, we cannot remove a public API. The best thing we can do is to keep with
a deprecation warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
