dongjoon-hyun commented on code in PR #1574:
URL: https://github.com/apache/orc/pull/1574#discussion_r1290619552


##########
java/core/src/java/org/apache/orc/DataReader.java:
##########
@@ -55,8 +55,14 @@ BufferChunkList readFileData(BufferChunkList range,
    * Releases buffers created by readFileData. See readFileData javadoc.
    * @param toRelease The buffer to release.
    */
+  @Deprecated

Review Comment:
   In order to deprecate properly, we need additional Javadoc message with the 
alternative usage, e.g., `Use ... instead`. Please see the example.
   
   
https://github.com/apache/orc/blob/3d9aa415d28d5f9d21d389018441cb499983f2d8/java/core/src/java/org/apache/orc/OrcConf.java#L306-L313



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to