dongjoon-hyun commented on code in PR #1575: URL: https://github.com/apache/orc/pull/1575#discussion_r1288842722
########## java/core/src/test/org/apache/orc/TestColumnStatistics.java: ########## @@ -28,6 +27,7 @@ import org.apache.hadoop.hive.serde2.io.DateWritable; import org.apache.hadoop.hive.serde2.io.HiveDecimalWritable; import org.apache.hadoop.io.Text; +import org.apache.hadoop.shaded.org.apache.commons.text.StringEscapeUtils; Review Comment: `*.shaded.` is supposed to be used by the original project only. Depending on other project's shaded dependency is worse than using a deprecated dependency. I agree with @wgtmac 's concern. Let's remove this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
