dongjoon-hyun commented on code in PR #1575: URL: https://github.com/apache/orc/pull/1575#discussion_r1288932575
########## java/core/src/test/org/apache/orc/TestColumnStatistics.java: ########## @@ -28,6 +27,7 @@ import org.apache.hadoop.hive.serde2.io.DateWritable; import org.apache.hadoop.hive.serde2.io.HiveDecimalWritable; import org.apache.hadoop.io.Text; +import org.apache.hadoop.shaded.org.apache.commons.text.StringEscapeUtils; Review Comment: The PR description will be the commit log. Please clean up the discussion history (like ~~2. Deprecation on commons-lang StringEscapeUtils~~) there, @mystic-lama . It only makes confusions when someone reads a commit log. The commit log had better be independent, concise and complete by itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
