mystic-lama commented on code in PR #1587:
URL: https://github.com/apache/orc/pull/1587#discussion_r1295983141
##########
c++/src/Timezone.cc:
##########
@@ -675,6 +675,13 @@ namespace orc {
if (itr != timezoneCache.end()) {
return *(itr->second).get();
}
+ if (!std::filesystem::exists(std::filesystem::path(filename))) {
+ std::stringstream ss;
+ ss << "Time zone file " << filename << " does not exist."
+ << " Please install IANA time zone database and set TZDIR env
properly"
Review Comment:
Just a suggestion: Can rephrase as
"Please install IANA time zone database and set TZDIR env property to point
to /usr/share/zoneinfo" or something like that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
