mystic-lama commented on code in PR #1587:
URL: https://github.com/apache/orc/pull/1587#discussion_r1296105988
##########
c++/src/Timezone.cc:
##########
@@ -675,6 +675,13 @@ namespace orc {
if (itr != timezoneCache.end()) {
return *(itr->second).get();
}
+ if (!std::filesystem::exists(std::filesystem::path(filename))) {
+ std::stringstream ss;
+ ss << "Time zone file " << filename << " does not exist."
+ << " Please install IANA time zone database and set TZDIR env
properly"
Review Comment:
minor nit:
... set TZDIR env to point to correct location, if not installed....
I am just wearing a user's hat and trying to see if the message helps me
resolve things. Please note that English is not my 1st language
@wgtmac Thanks :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
