wgtmac commented on code in PR #1587:
URL: https://github.com/apache/orc/pull/1587#discussion_r1300870195
##########
c++/src/Timezone.cc:
##########
@@ -675,6 +675,13 @@ namespace orc {
if (itr != timezoneCache.end()) {
return *(itr->second).get();
}
+ if (!std::filesystem::exists(std::filesystem::path(filename))) {
Review Comment:
Yes, I just want to check proactively before reading it so the error message
is clear. It may fail reading due to other reasons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
