dongjoon-hyun commented on code in PR #1740:
URL: https://github.com/apache/orc/pull/1740#discussion_r1447688404
##########
java/bench/hive/src/java/org/apache/orc/bench/hive/rowfilter/BooleanRowFilterBenchmark.java:
##########
@@ -91,10 +91,14 @@ public void readOrcNoFilter(Blackhole blackhole, InputState
state) throws Except
* Run this test:
* java -cp hive/target/orc-benchmarks-hive-*-uber.jar
org.apache.orc.bench.hive.rowfilter.BooleanRowFilterBenchmark
*/
- public static void main(String[] args) throws RunnerException {
- new Runner(new OptionsBuilder()
- .include(BooleanRowFilterBenchmark.class.getSimpleName())
- .forks(1)
- .build()).run();
+ public static void main(String[] args) {
Review Comment:
Do you know why this change is required? Apache ORC code follows the
official JMHSample file.
-
https://github.com/openjdk/jmh/blob/cb3c3a90137dad781a2a37fda72dc11ebf253593/jmh-samples/src/main/java/org/openjdk/jmh/samples/JMHSample_01_HelloWorld.java#L95
```java
public static void main(String[] args) throws RunnerException {
Options opt = new OptionsBuilder()
.include(JMHSample_01_HelloWorld.class.getSimpleName())
.forks(1)
.build();
new Runner(opt).run();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
