cxzl25 commented on code in PR #1740:
URL: https://github.com/apache/orc/pull/1740#discussion_r1448246983
##########
java/bench/hive/src/java/org/apache/orc/bench/hive/rowfilter/BooleanRowFilterBenchmark.java:
##########
@@ -91,10 +91,14 @@ public void readOrcNoFilter(Blackhole blackhole, InputState
state) throws Except
* Run this test:
* java -cp hive/target/orc-benchmarks-hive-*-uber.jar
org.apache.orc.bench.hive.rowfilter.BooleanRowFilterBenchmark
*/
- public static void main(String[] args) throws RunnerException {
- new Runner(new OptionsBuilder()
- .include(BooleanRowFilterBenchmark.class.getSimpleName())
- .forks(1)
- .build()).run();
+ public static void main(String[] args) {
Review Comment:
```
'main(String[])' in
'org.apache.orc.bench.hive.rowfilter.BooleanRowFilterBenchmark' clashes with
'main(String[])' in 'org.openjdk.jmh.Main'; overridden method does not throw
'org.openjdk.jmh.runner.RunnerException'
```
Because these Benchmarks inherit `extends org.openjdk.jmh.Main`,
`org.openjdk.jmh.Main` removed the method throwing `RunnerException` in `1.23`.
https://github.com/openjdk/jmh/commit/4264de9486c32b48da8161e3ac076a0187b4176f#diff-30878bccaff9f11a64415de78f1feebe304334a314d8bb6f8c7bc50bd21aee19L39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
