dongjoon-hyun commented on code in PR #1749:
URL: https://github.com/apache/orc/pull/1749#discussion_r1453652434
##########
java/CMakeLists.txt:
##########
@@ -97,7 +97,7 @@ add_test(
add_test(
NAME java-bench-spark-test
- COMMAND java ${ADD_OPENS} ${JAVA_NIO} -jar
bench/spark/orc-benchmarks-spark-${ORC_VERSION}.jar spark data -d sales -c zstd
-f orc
+ COMMAND java ${ADD_OPENS} ${JAVA_NIO} -jar
bench/spark/orc-benchmarks-spark-${ORC_VERSION}-shaded.jar spark data -d sales
-c zstd -f orc
Review Comment:
You described `-nohive `in the PR description like the following, but we
don't use `-nohive` at line 100.
May I ask why you did propose to change a working code by giving an
irrelevant example?
```
Error: Invalid or corrupt jarfile
spark/target/orc-benchmarks-spark-2.1.0-SNAPSHOT-nohive.jar
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
