cxzl25 commented on code in PR #1749:
URL: https://github.com/apache/orc/pull/1749#discussion_r1454536564
##########
java/CMakeLists.txt:
##########
@@ -97,7 +97,7 @@ add_test(
add_test(
NAME java-bench-spark-test
- COMMAND java ${ADD_OPENS} ${JAVA_NIO} -jar
bench/spark/orc-benchmarks-spark-${ORC_VERSION}.jar spark data -d sales -c zstd
-f orc
+ COMMAND java ${ADD_OPENS} ${JAVA_NIO} -jar
bench/spark/orc-benchmarks-spark-${ORC_VERSION}-shaded.jar spark data -d sales
-c zstd -f orc
Review Comment:
I get an error when I do the following according to the README of bench.
Since `bench/core`, `bench/hive` are packaged with `maven-assembly-plugin`,
the jar contains uber, and bench/spark is packaged with `maven-shade-plugin`,
the generated jar file name doesn't contain `shaded` in case
`shadedArtifactAttached= false`, the generated jar filename does not contain
`shaded`.
```bash
cd java
./mvnw clean package -Pbenchmark -DskipTests
cd bench
java -jar spark/target/orc-benchmarks-spark-*.jar spark data
```
```
Error: Invalid or corrupt jarfile
spark/target/orc-benchmarks-spark-2.1.0-SNAPSHOT-nohive.jar
```
bench/spark/target
```
-rw-r--r--@ 1 csy staff 2.1M 1 17 12:03
orc-benchmarks-spark-2.1.0-SNAPSHOT-nohive.jar
-rw-r--r-- 1 csy staff 1.8M 1 17 12:03
orc-benchmarks-spark-2.1.0-SNAPSHOT-shaded-protobuf.jar
-rw-r--r-- 1 csy staff 39K 1 17 12:03
orc-benchmarks-spark-2.1.0-SNAPSHOT-sources.jar
-rw-r--r-- 1 csy staff 13K 1 17 12:03
orc-benchmarks-spark-2.1.0-SNAPSHOT-test-sources.jar
-rw-r--r-- 1 csy staff 13K 1 17 12:04
orc-benchmarks-spark-2.1.0-SNAPSHOT-tests.jar
-rw-r--r--@ 1 csy staff 217M 1 17 12:04
orc-benchmarks-spark-2.1.0-SNAPSHOT.jar
-rw-r--r-- 1 csy staff 64K 1 17 12:03
original-orc-benchmarks-spark-2.1.0-SNAPSHOT.jar
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
