wgtmac commented on code in PR #1826:
URL: https://github.com/apache/orc/pull/1826#discussion_r1503825832
##########
c++/src/ColumnPrinter.cc:
##########
@@ -639,7 +639,7 @@ namespace orc {
if (i != 0) {
writeString(buffer, ", ");
}
- const auto numBuffer = std::to_string(static_cast<const
int>(start[rowId][i]) & 0xff);
+ const auto numBuffer =
std::to_string(static_cast<int>(start[rowId][i]) & 0xff);
Review Comment:
All code changes are due to warnings and errors that appear after the flag
changes. What about reflecting these in the description rather than in the
title?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
