dongjoon-hyun commented on code in PR #1826:
URL: https://github.com/apache/orc/pull/1826#discussion_r1504506442
##########
c++/src/ColumnPrinter.cc:
##########
@@ -639,7 +639,7 @@ namespace orc {
if (i != 0) {
writeString(buffer, ", ");
}
- const auto numBuffer = std::to_string(static_cast<const
int>(start[rowId][i]) & 0xff);
+ const auto numBuffer =
std::to_string(static_cast<int>(start[rowId][i]) & 0xff);
Review Comment:
Only PR title has some misleading point because it could be interpreted that
this PR only changes CMakefile.
> Reduce unnecessary compiler flags in CMake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
