stiga-huang commented on code in PR #1855:
URL: https://github.com/apache/orc/pull/1855#discussion_r1538730140
##########
c++/include/orc/Exceptions.hh:
##########
@@ -28,8 +28,8 @@ namespace orc {
class NotImplementedYet : public std::logic_error {
public:
- explicit NotImplementedYet(const std::string& what_arg);
- explicit NotImplementedYet(const char* what_arg);
+ explicit NotImplementedYet(const std::string& whatArg);
+ explicit NotImplementedYet(const char* whatArg);
Review Comment:
Do we consider using snake case instead of mixed case (camel case) for
variable names? Impala C++ Code follows a modified version of the Google C++
Style Guide at:
https://google.github.io/styleguide/cppguide.html#Variable_Names
I think either way is ok. Just remembered that when I first read the ORC C++
code, they look like Java code. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
