ffacs commented on code in PR #1855:
URL: https://github.com/apache/orc/pull/1855#discussion_r1538936858
##########
c++/include/orc/Exceptions.hh:
##########
@@ -28,8 +28,8 @@ namespace orc {
class NotImplementedYet : public std::logic_error {
public:
- explicit NotImplementedYet(const std::string& what_arg);
- explicit NotImplementedYet(const char* what_arg);
+ explicit NotImplementedYet(const std::string& whatArg);
+ explicit NotImplementedYet(const char* whatArg);
Review Comment:
There are lots of public/protected variables using camel case, if we change
them into snake case, the library codes would be not backwards compatible.
Backwards compatibility is important, I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
