luffy-zh commented on code in PR #2010:
URL: https://github.com/apache/orc/pull/2010#discussion_r1734068573
##########
c++/include/orc/Vector.hh:
##########
@@ -248,10 +249,15 @@ namespace orc {
~EncodedStringVectorBatch() override;
std::string toString() const override;
void resize(uint64_t capacity) override;
+
+ // Calculate data and length in StringVectorBatch from dictionary and index
+ void calculateDataAndLength();
+
std::shared_ptr<StringDictionary> dictionary;
// index for dictionary entry
DataBuffer<int64_t> index;
+ std::atomic<bool> calculated{false};
Review Comment:
Sorry for the late comment. All members of the ColumnVectorBatch class are
non-atomic. It is assumed that the ColumnVectorBatch object will not be shared
or reused across multiple threads. Could you share the code in ClickHouse that
invokes decodeDictionary()?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
