taiyang-li commented on PR #2010: URL: https://github.com/apache/orc/pull/2010#issuecomment-2309459294
I added a benchmark (https://github.com/ClickHouse/ClickHouse/blob/1011f8ef9c2511654937c96b7bea7693a4c9715f/src/Common/benchmarks/orc_string_dictionary.cpp) to measure performance changes after this pr. Here is the result: ``` $ ./build_gcc/src/Common/benchmarks/orc_string_dictionary 2024-08-26T14:43:53+08:00 Running ./build_gcc/src/Common/benchmarks/orc_string_dictionary Run on (32 X 2100 MHz CPU s) CPU Caches: L1 Data 32 KiB (x16) L1 Instruction 32 KiB (x16) L2 Unified 1024 KiB (x16) L3 Unified 11264 KiB (x2) Load Average: 5.79, 5.70, 5.88 ---------------------------------------------------------------------------------------------- Benchmark Time CPU Iterations ---------------------------------------------------------------------------------------------- BM_writeStringDictionary<OldSortedStringDictionary> 148905832 ns 148900910 ns 5 BM_writeStringDictionary<NewSortedStringDictionary> 86750854 ns 86747873 ns 8 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
