taiyang-li commented on code in PR #2048:
URL: https://github.com/apache/orc/pull/2048#discussion_r1816104420


##########
c++/include/orc/Reader.hh:
##########
@@ -605,6 +612,26 @@ namespace orc {
      */
     virtual std::map<uint32_t, BloomFilterIndex> getBloomFilters(
         uint32_t stripeIndex, const std::set<uint32_t>& included) const = 0;
+
+    /**
+     * Get the input stream for the ORC file.
+     */
+    virtual InputStream* getStream() const = 0;
+
+    /**
+     * Get the footer of the ORC file.
+     */
+    virtual const proto::Footer* getFooter() const = 0;

Review Comment:
   @wgtmac I found it is needed by 
https://github.com/bigo-sg/ClickHouse/blob/6e9d19fdd05bf951323c7b89c7d8c9089a604f0b/src/Processors/Formats/Impl/NativeORCBlockInputFormat.cpp#L990-L991
 to get candidate stripes to prefetch.
   
   Related pr: https://github.com/ClickHouse/ClickHouse/pull/70534  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to