taiyang-li commented on code in PR #2048:
URL: https://github.com/apache/orc/pull/2048#discussion_r1816285218
##########
c++/src/MemoryPool.cc:
##########
@@ -134,9 +130,6 @@ namespace orc {
template <>
void DataBuffer<char>::resize(uint64_t newSize) {
reserve(newSize);
- if (newSize > currentSize_) {
Review Comment:
> Do you think it makes sence if we add a build option like
`MEMSET_AFTER_RESIZE` with false as default value.
already reverted. But I still think it is worth to try. If you think the
solution is ok, I'll do it in another newe pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
