taiyang-li commented on code in PR #2048:
URL: https://github.com/apache/orc/pull/2048#discussion_r1847533445
##########
c++/include/orc/OrcFile.hh:
##########
@@ -58,6 +73,17 @@ namespace orc {
*/
virtual void read(void* buf, uint64_t length, uint64_t offset) = 0;
+ /**
+ * Read data asynchronously.
+ * @param offset the position in the stream to read from.
+ * @param length the number of bytes to read.
+ * @return a future that will be set to the buffer when the read is
complete.
+ */
+ virtual std::future<BufferPtr> readAsync(uint64_t /*offset*/, uint64_t
/*length*/,
Review Comment:
@wgtmac @ffacs I had renamed the old interface to `readAsyncInternal` and
moved it under `protected`. User could not invoke it. What user could see is
the new interface `readAsync`. And it has a default implementation. Users could
override it if they are not satisfied with it. Thanks for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
