taiyang-li commented on code in PR #2048:
URL: https://github.com/apache/orc/pull/2048#discussion_r1851272704
##########
c++/include/orc/Reader.hh:
##########
@@ -39,6 +39,8 @@ namespace orc {
// classes that hold data members so we can maintain binary compatibility
struct ReaderOptionsPrivate;
struct RowReaderOptionsPrivate;
+ struct CacheOptions;
Review Comment:
I think `CacheOptions` being exposed to user is not a big deal, since cache
related metrics is already exposed.
##########
c++/include/orc/Reader.hh:
##########
@@ -39,6 +39,8 @@ namespace orc {
// classes that hold data members so we can maintain binary compatibility
struct ReaderOptionsPrivate;
struct RowReaderOptionsPrivate;
+ struct CacheOptions;
Review Comment:
I think `CacheOptions` being exposed to user is not a big deal, since cache
related metrics are already exposed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
