deshanxiao commented on code in PR #2076:
URL: https://github.com/apache/orc/pull/2076#discussion_r1861444110
##########
cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -153,6 +153,12 @@ if (ORC_PACKAGE_KIND STREQUAL "conan")
add_resolved_library (orc_snappy ${Snappy_LIBRARIES} ${Snappy_INCLUDE_DIR})
list (APPEND ORC_SYSTEM_DEPENDENCIES Snappy)
list (APPEND ORC_INSTALL_INTERFACE_TARGETS
"$<INSTALL_INTERFACE:Snappy::snappy>")
+elseif (ORC_PACKAGE_KIND STREQUAL "vcpkg")
+ find_package(Snappy CONFIG REQUIRED)
+ add_library (orc_snappy INTERFACE IMPORTED)
+ target_link_libraries(orc_snappy INTERFACE Snappy::snappy)
Review Comment:
@wgtmac Actually, we don't call target_include_directories here, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
