deshanxiao commented on code in PR #2076:
URL: https://github.com/apache/orc/pull/2076#discussion_r1861444808
##########
cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -197,6 +203,13 @@ if (ORC_PACKAGE_KIND STREQUAL "conan")
add_resolved_library (orc_zlib ${ZLIB_LIBRARIES} ${ZLIB_INCLUDE_DIR})
list (APPEND ORC_SYSTEM_DEPENDENCIES ZLIB)
list (APPEND ORC_INSTALL_INTERFACE_TARGETS "$<INSTALL_INTERFACE:ZLIB::ZLIB>")
+elseif (ORC_PACKAGE_KIND STREQUAL "vcpkg")
+ find_package(ZLIB REQUIRED)
+ add_library (orc_zlib INTERFACE IMPORTED)
+ target_link_libraries(orc_zlib INTERFACE ZLIB::ZLIB)
+ list (APPEND ORC_VCPKG_DEPENDENCIES ZLIB)
Review Comment:
Good catch, thanks @wgtmac
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
