wankunde commented on code in PR #2371:
URL: https://github.com/apache/orc/pull/2371#discussion_r2361912574


##########
java/core/src/java/org/apache/orc/OrcConf.java:
##########
@@ -182,6 +187,11 @@ public enum OrcConf {
       "added to all of the writers.  Valid range is [1,10000] and is primarily 
meant for" +
       "testing.  Setting this too low may negatively affect performance."
         + " Use orc.stripe.row.count instead if the value larger than 
orc.stripe.row.count."),
+  STRIPE_SIZE_CHECKRATIO("orc.stripe.size.checkRatio",
+      "hive.exec.orc.default.stripe.size.checkRatio",
+      2.0,
+      "Flush stripe if the tree writer size in bytes is larger than (this * 
orc.stripe.size), " +
+          "use 0 to disable this check."),

Review Comment:
   Done



##########
java/core/src/java/org/apache/orc/impl/WriterImpl.java:
##########
@@ -112,6 +112,7 @@ public class WriterImpl implements WriterInternal, 
MemoryManager.Callback {
   private long previousAllocation = -1;
   private long memoryLimit;
   private final long ROWS_PER_CHECK;
+  private final double STRIPE_SIZE_CHECK;

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@orc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to