cxzl25 commented on code in PR #2371:
URL: https://github.com/apache/orc/pull/2371#discussion_r2371835867
##########
java/core/src/java/org/apache/orc/impl/WriterImpl.java:
##########
@@ -224,6 +225,8 @@ public WriterImpl(FileSystem fs,
this.stripeRowCount= opts.getStripeRowCountValue();
this.stripeSize = opts.getStripeSize();
memoryLimit = stripeSize;
+ double stripeSizeCheckRatio =
OrcConf.STRIPE_SIZE_CHECKRATIO.getDouble(conf);
+ STRIPE_SIZE_PER_CHECK = stripeSizeCheckRatio <= 0 ? 0 :
stripeSizeCheckRatio * memoryLimit;
Review Comment:
```suggestion
STRIPE_SIZE_PER_CHECK = stripeSizeCheckRatio <= 0 ? 0 :
stripeSizeCheckRatio * stripeSize;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@orc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
