cxorm commented on a change in pull request #1584:
URL: https://github.com/apache/ozone/pull/1584#discussion_r523424197
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/acl/OMBucketAddAclRequest.java
##########
@@ -130,5 +131,12 @@ void onComplete(boolean operationResult, IOException
exception,
}
}
+ @Override
+ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
+ long trxnLogIndex, OzoneManagerDoubleBufferHelper omDoubleBufferHelper) {
+ ozoneManager.getMetrics().incNumAddAcl();
Review comment:
> Thanx @cxorm for the review. In `onComplete()`, there doesn't seems to
be any instance of `ozoneManager` available, and I quickly had a check over,
couple of other files, they too were incrementing metrics in
`validateAndUpdateCache`, I think we can be in sync with them.
Thanks @ayushtkn for the comment.
IMHO the `onComplete()` is called by super class `validateAndUpdateCache`
(for example, in this part its super class is `OMBucketAclRequest`), and it has
instance of `ozoneManager`.
An operation scenario is that when we call
`ozoneManager.getMetrics().incNumAddAcl()` before
`super.validateAndUpdateCache()` and failure occurs in
`validateAndUpdateCache()`, the `incNumAddAcl()` shouldn't take effect, but it
did.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
