ayushtkn commented on a change in pull request #1584:
URL: https://github.com/apache/ozone/pull/1584#discussion_r523426883
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/acl/OMBucketAddAclRequest.java
##########
@@ -130,5 +131,12 @@ void onComplete(boolean operationResult, IOException
exception,
}
}
+ @Override
+ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
+ long trxnLogIndex, OzoneManagerDoubleBufferHelper omDoubleBufferHelper) {
+ ozoneManager.getMetrics().incNumAddAcl();
Review comment:
Thanx @cxorm
Are you talking about this `onComplete`?
https://github.com/apache/ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/volume/acl/OMVolumeAddAclRequest.java#L114
If not can you point me to that. It doesn't have `ozonemanager`
>An operation scenario is that when we call
ozoneManager.getMetrics().incNumAddAcl() before super.validateAndUpdateCache()
and failure occurs in validateAndUpdateCache(), the incNumAddAcl() shouldn't
take effect, but it did.
Aren't these metrics suppose to track the number of calls? not just success?
`validateAndUpdateCache ` too has a metrics getting incremented, `
omMetrics.incNumVolumeUpdates();`, if a failure occurs post that, it isn't
bothered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
