linyiqun commented on a change in pull request #1611:
URL: https://github.com/apache/ozone/pull/1611#discussion_r530285817



##########
File path: 
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java
##########
@@ -1166,4 +1172,107 @@ public String getClusterId() {
   public HDDSLayoutVersionManager getLayoutVersionManager() {
     return scmLayoutVersionManager;
   }
+
+  private void waitForAllContainersToClose() {

Review comment:
       Agree the point that @avijayanhwx  mentioned. With the number of 
containers/pipeline becomes more large, this operation cal be very costly. can 
we just add a flag switch to avoid write type ops for container/pipelines, like 
freezePipelineCreation we added above.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to