prashantpogde commented on pull request #1611: URL: https://github.com/apache/ozone/pull/1611#issuecomment-734008365
> > I am thinking about the refactor of the UpgradeFinalizer. > In the BasicFinalizer, there is a finalizeFeature, that is called from the SCMUpgradeFinalizer, while the OMUpgradeFinalizer has its own finalizeFeature method. .... .... > I started to think about this because of the similarities in the two concrete UpgradeFinalizer, and the two pretty much different approach on how we handled the Optional UpgradeAction : Earlier I was keeping worker also in the Basic UpgradeFinalizer as you suggested but it seemed Om finalization didnt need pre/post hook. So left it this way. We can also discuss this in a call. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
