fapifta commented on pull request #1667: URL: https://github.com/apache/ozone/pull/1667#issuecomment-745217645
Hi Attila, thank you for addressing review comments of mine, and going further and find way more cases than I did! Regarding the CONF_DIR environment variables, I would say we should fix it properly, and I understand that updating the docker images would be a pain, and a bit of a tedious project, and this task is already tedious. On the other hand, we learned that the envtoconf.py may change over time, as requirements are changing, I don't think that option two is hacky. It is hacky in a way that we overwrite a file backed into the docker images, but on the other hand, I would argue that the file should not be in the docker image itself, as even if this does not happen often, the file changes from time to time, so we should preserve the possibility to change it easily. What do you think? Ofc, a properly done option two would require to modify all the images to leave out envtoconf.py, and to modify all the docker-compose file to mount the file into the image, which is again even more tedious. What if as part of this JIRA you add the mount to the docker compose files, and we create a follow up jira to remove the file from containers? In return I can offer to volunteer for doing the docker image update, though I might need some help with it, but I really don't want to break this convention ;) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
