fapifta commented on pull request #1667: URL: https://github.com/apache/ozone/pull/1667#issuecomment-746451810
Hi @adoroszlai, thank you for addressing my concern and revert back to OZONE_CONF_DIR. Let me ask as I did not have the time to go through and understand fully the transformation.py usage and how that effects the environment processing that is problematic with env vars with names like *CONF*, and to understand what is happening exactly as the consequence of your change? Now I am guessing, but based on your change envtoconf.py is using transformation.py and with adding it to the docker-compose.yaml file, we effectively overriding the original transformation.py that is backed into the image(?). The change itself in transformation.py is to go through the items instead of the collection means that we are transforming something different in those cases and we do it similarly as the one case you mentioned working well before this change also, I am not sure though, how this solves the problem. Can you please give me some pointers where should I see what makes the difference or can you please point out the difference for me to understand a bit more easily what is happening? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
