hanishakoneru commented on a change in pull request #1494:
URL: https://github.com/apache/ozone/pull/1494#discussion_r544695250



##########
File path: 
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -2707,6 +2728,57 @@ public ServiceInfoEx getServiceInfo() throws IOException 
{
     return new ServiceInfoEx(getServiceList(), caCertPem);
   }
 
+  @Override
+  public boolean bootstrap(List<OMNodeInfo> omNodeInfos) throws IOException {
+    LOG.error("OM bootstrap command should be received via the RPC server");
+    throw new UnsupportedOperationException("OM bootstrap command should be " +
+        "received via the RPC server");
+  }
+
+  /**
+   * Add a new OM Node to the HA cluster.
+   */
+  public void addNewOMNode(String newOMNodeId) {
+    OMNodeDetails newOMNodeDetails = OMNodeDetails.getOMNodeDetailsFromConf(
+        getConfiguration(), getOMServiceId(), newOMNodeId);
+    if (newOMNodeDetails == null) {
+      // Load new configuration object to read in new peer information
+      setConfiguration(new OzoneConfiguration());

Review comment:
       This is run on all OMs (old OMs also). OzoneManager#addNewOMNode() is 
called when Ratis sends notifyConfigurationChanged(). And since the old OMs are 
not necessarily restarted, we need to reload the configuration.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to