hanishakoneru commented on a change in pull request #1494:
URL: https://github.com/apache/ozone/pull/1494#discussion_r544699256
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerStateMachine.java
##########
@@ -388,6 +412,15 @@ public String
toStateMachineLogEntryString(StateMachineLogEntryProto proto) {
return OMRatisHelper.smProtoToString(proto);
}
+ @Override
+ public void close() throws IOException {
+ // OM should be shutdown as the StateMachine has shutdown.
Review comment:
If the StateMachine has terminated for any reason, then the OM should
also be terminated.
This is not just for notifyConfigurationChanged exception. If the RaftServer
shutsdown for reason, we want the OM also to shutdown. Though the OM would not
service write requests any more, the shutdown would not be visible to user as
OM is still running.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
