linyiqun edited a comment on pull request #1746: URL: https://github.com/apache/ozone/pull/1746#issuecomment-753425854
>First we need to be able to distinguish whether the user sets quota to 0 (users may not specify Quoat when creating volumes and buckets, long is undefined as 0 by default and should be successful), and then judge the validity based on this. I don't fully get why we need to distinguish whether the user sets quota to 0. Could we just make this two cases be quota disabled? If the quota returned value is 0, we could return a Quota.RESET value instead of. In addition, we don't allow 0 could be set by cli command after above change. It looks confused we pass a string type value for namespace quota. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
