captainzmc edited a comment on pull request #1746:
URL: https://github.com/apache/ozone/pull/1746#issuecomment-754432275


   Hi @linyiqun @ayushtkn Sorry for the late reply, we can continue to discuss 
this problem.
   Maybe I didn't make it clear before, let's do an example:
   ozone sh bucket create vol1 (This should be success)
   ozone sh bucket create vol1 --namespace-quota 0 (This should be unsuccessful)
   
    These are two different cases. But both cases in [CreateVolumeHandler 
quotaOptions.getQuotaInNamespace()](https://github.com/apache/ozone/blob/master/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/volume/CreateVolumeHandler.java#L68)
 is 0.
   
![image](https://user-images.githubusercontent.com/13825159/103613149-f1f8c800-4f60-11eb-9a23-5bf675f04277.png)
   
   In client side, different cases  has the same parameters. Because the long 
variable is also 0 by default when it is not declared.
   
   Let's look at another example,this also has the same problem:
    ozone sh volume setquota vol1 --space-quota 10TB (This should be success)
    ozone sh volume setquota vol1 --space-quota 10TB --namespace-quota 0 (This 
should be unsuccessful)
   
   Because of this, I changed long to a string. This should be the most direct 
way.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to