xiaoyuyao commented on a change in pull request #1734:
URL: https://github.com/apache/ozone/pull/1734#discussion_r551647922
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/volume/acl/OMVolumeSetAclRequest.java
##########
@@ -88,6 +92,12 @@ public String getVolumeName() {
return volumeName;
}
+ @Override
+ OzoneObjInfo getObjectInfo() {
+ return OzoneObjInfo.fromProtobuf(
+ getOmRequest().getSetAclRequest().getObj());
Review comment:
NIT: this can be put into the constructor with a member variable so that
the protobuf conversion is done only once and the getter() simply return the
member variable. Same apply to other places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
