dineshchitlangia commented on a change in pull request #1734:
URL: https://github.com/apache/ozone/pull/1734#discussion_r555211744
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/acl/OMBucketAddAclRequest.java
##########
@@ -116,7 +126,11 @@ OMClientResponse onFailure(OMResponse.Builder omResponse,
@Override
void onComplete(boolean operationResult, IOException exception,
- OMMetrics omMetrics) {
+ OMMetrics omMetrics, AuditLogger auditLogger,
+ Map<String, String> auditMap) {
+ auditLog(auditLogger, buildAuditMessage(OMAction.ADD_ACL, auditMap,
+ exception, getOmRequest().getUserInfo()));
Review comment:
```suggestion
if (operationResult) {
LOG.debug("Add acl: {} to path: {} success!", getAcls(), getPath());
} else {
omMetrics.incNumBucketUpdateFails();
if (exception == null) {
LOG.error("Add acl {} to path {} failed, because acl already exist",
getAcls(), getPath());
exception = new ACLAlreadyExistsException(); //we can create this
new type of exception
} else {
LOG.error("Add acl {} to path {} failed!", getAcls(), getPath(),
exception);
}
}
auditLog(auditLogger, buildAuditMessage(OMAction.ADD_ACL, auditMap,
exception, getOmRequest().getUserInfo()));
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
