amaliujia commented on a change in pull request #1756:
URL: https://github.com/apache/ozone/pull/1756#discussion_r551670693



##########
File path: 
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/RatisUtil.java
##########
@@ -149,7 +149,8 @@ private static void setRaftRetryCacheProperties(
   private static void setRaftSnapshotProperties(
       final RaftProperties properties, final SCMHAConfiguration conf) {
     Snapshot.setAutoTriggerEnabled(properties, true);
-    Snapshot.setAutoTriggerThreshold(properties, 400000);
+    Snapshot.setAutoTriggerThreshold(properties,
+        conf.getRatisSnapshotThreshold());

Review comment:
       This is useful for both writing unit tests for snapshot functionality 
and allow users to set their own threshold




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to