GlenGeng commented on a change in pull request #1756:
URL: https://github.com/apache/ozone/pull/1756#discussion_r551701803
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMHAConfiguration.java
##########
@@ -114,6 +114,14 @@
)
private int raftLogPurgeGap = 1000000;
+ @Config(key = "ratis.snapshot.threshold",
+ type = ConfigType.LONG,
+ defaultValue = "100000L",
+ tags = {SCM, OZONE, HA, RATIS},
+ description = "The threshold to trigger a Ratis taking snapshot " +
+ "operation")
Review comment:
operation -> operation for SCM.
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMHAConfiguration.java
##########
@@ -114,6 +114,14 @@
)
private int raftLogPurgeGap = 1000000;
+ @Config(key = "ratis.snapshot.threshold",
+ type = ConfigType.LONG,
+ defaultValue = "100000L",
+ tags = {SCM, OZONE, HA, RATIS},
+ description = "The threshold to trigger a Ratis taking snapshot " +
+ "operation")
+ private long ratisSnapshotThreshold = 100000L;
Review comment:
100000L might be too large for SCM, since the WriteBatch needs hold them
in memory and the flush will block the apply of transactions. How about 500 or
1000 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
