avijayanhwx commented on a change in pull request #1720:
URL: https://github.com/apache/ozone/pull/1720#discussion_r553132176
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/upgrade/HDDSLayoutFeatureCatalog.java
##########
@@ -39,7 +40,11 @@
private int layoutVersion;
private String description;
- private Optional< ? extends HDDSUpgradeAction> hddsUpgradeAction =
+
+ private Optional<? extends HDDSUpgradeAction> scmUpgradeAction =
+ Optional.empty();
+
+ private Optional<? extends HDDSUpgradeAction> datanodeUpgradeAction =
Review comment:
I am wondering whether the organization of modules will cause a problem
here. The DatanodeStateMachine class is in container-service module, while this
class (HDDSLayoutFeatureCatalog) is in hdds-common. The common module is
usually shared across the the more specific modules. Where does one create an
upgrade action for the Datanode? If the action is in container-service, then it
cannot be accessed in hdds-common, if the action is in common, then it cannot
access the DatanodeStateMachine class.
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/upgrade/DataNodeUpgradeAction.java
##########
@@ -0,0 +1,31 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.container.upgrade;
+
+import org.apache.hadoop.hdds.upgrade.HDDSUpgradeAction;
+import
org.apache.hadoop.ozone.container.common.statemachine.DatanodeStateMachine;
+
+/**
+ * Upgrade Action for DataNode which takes in a 'DataNodeStateMachine'
instance.
+ */
+public class DataNodeUpgradeAction extends
Review comment:
Can we have DataNodeUpgradeAction and SCMUpgradeAction as an interface
or abstract class?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
